Skip to content

Conversation

@Preeticp
Copy link
Contributor

@Preeticp Preeticp commented Feb 8, 2021

Aligned team: DevTools
Applicable Version: 4.7
We have acks from respective team leads, and Stephanie and Vikram.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 8, 2021
@netlify
Copy link

netlify bot commented Feb 8, 2021

Deploy preview for osdocs ready!

Built with commit 85f4fe6

https://deploy-preview-29252--osdocs.netlify.app

minor edits

move docs to cicd dir

dir name mod

modifying xref

modifying xrefs

fixing xrefs

fixing xrefs

fixing xrefs3

fix xrefs

updating xrefs

updating xrefs2

updating xrefs3

updating xrefs4

xref fixes

updating module name
@Preeticp
Copy link
Contributor Author

Preeticp commented Feb 9, 2021

/devtools

@jboxman jboxman added dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs branch/enterprise-4.7 labels Feb 9, 2021
@jboxman
Copy link
Contributor

jboxman commented Feb 9, 2021

@Preeticp thanks for calling out labels!

@jboxman jboxman added this to the Future Release milestone Feb 9, 2021
@jboxman
Copy link
Contributor

jboxman commented Feb 9, 2021

@Preeticp

I think this needs a symlink cicd/pipelines/images => ../../images.

asciidoctor: WARNING: image to embed not found or not readable: /Users/jasonb/Self/work/openshift-docs/cicd/pipelines/images/op-pipeline-builder.png
asciidoctor: WARNING: image to embed not found or not readable: /Users/jasonb/Self/work/openshift-docs/cicd/pipelines/images/op-pipeline-builder-task-details.png
asciidoctor: WARNING: image to embed not found or not readable: /Users/jasonb/Self/work/openshift-docs/cicd/pipelines/images/op-pipeline-list.png
asciidoctor: WARNING: image to embed not found or not readable: /Users/jasonb/Self/work/openshift-docs/cicd/pipelines/images/kebab.png
asciidoctor: WARNING: image to embed not found or not readable: /Users/jasonb/Self/work/openshift-docs/cicd/pipelines/images/kebab.png
asciidoctor: WARNING: image to embed not found or not readable: /Users/jasonb/Self/work/openshift-docs/cicd/pipelines/images/op_pipeline_run.png
asciidoctor: WARNING: image to embed not found or not readable: /Users/jasonb/Self/work/openshift-docs/cicd/pipelines/images/op_pipeline_topology.png
asciidoctor: WARNING: image to embed not found or not readable: /Users/jasonb/Self/work/openshift-docs/cicd/pipelines/images/kebab.png

Copy link
Contributor

@jboxman jboxman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the symlink for images needs to be ../.. just like the xref adjustments.

File: working-with-pipelines-using-the-developer-perspective
- Name: OpenShift Pipelines release notes
File: op-release-notes
#- Name: GitOps
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want this added, commented out? Or should that happen in a different PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we want to add this, and the entire reorg was initiated due to this component. But we don't have the content in place yet. Hence commented out. Is there a concern merging this commented out?
In the content PR we will add this with changes in the title as required, is that OK? This will come in slightly later, we spoke to Vikram and have an exception for this. Basically this component has an async release cycle from that of OCP.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay.

* xref:../../cicd/builds/creating-build-inputs.adoc#builds-input-secrets-configmaps_creating-build-inputs[Input secrets and config maps]
ifndef::openshift-origin[]
* xref:../../architecture/cicd_gitops.adoc#cicd_gitops[The CI/CD methodology and practice]
// **This section is being moved, update the link once content is in.* add link here[The CI/CD methodology and practice]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to update this when the time is right.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will add this with the content PR.

@jboxman jboxman added the peer-review-done Signifies that the peer review team has reviewed this PR label Feb 9, 2021
@Preeticp
Copy link
Contributor Author

Preeticp commented Feb 10, 2021

@jboxman I have fixed the images issue. The others we will fix with the content PR. Hope this is good to merge, if not let me know, please.

@jboxman jboxman merged commit 5266187 into openshift:master Feb 10, 2021
@jboxman
Copy link
Contributor

jboxman commented Feb 10, 2021

@Preeticp, I squashed the commit in GitHub. (So if you delete the branch with git branch -d <branch> git will complain that the commit isn't merged, but in this case it is.)

@jboxman
Copy link
Contributor

jboxman commented Feb 10, 2021

/cherry-pick enterprise-4.7

@openshift-cherrypick-robot

@jboxman: #29252 failed to apply on top of branch "enterprise-4.7":

Applying: cicd restructure
Using index info to reconstruct a base tree...
M	_topic_map.yml
M	applications/application_life_cycle_management/odc-creating-applications-using-developer-perspective.adoc
M	installing/install_config/customizations.adoc
Falling back to patching base and 3-way merge...
Auto-merging installing/install_config/customizations.adoc
CONFLICT (content): Merge conflict in cicd/pipelines/modules
CONFLICT (content): Merge conflict in cicd/pipelines/images
CONFLICT (content): Merge conflict in cicd/builds/modules
CONFLICT (content): Merge conflict in cicd/builds/images
Auto-merging applications/application_life_cycle_management/odc-creating-applications-using-developer-perspective.adoc
CONFLICT (content): Merge conflict in applications/application_life_cycle_management/odc-creating-applications-using-developer-perspective.adoc
Auto-merging _topic_map.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 cicd restructure
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherry-pick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Preeticp
Copy link
Contributor Author

Thank you, @jboxman

@jboxman
Copy link
Contributor

jboxman commented Feb 10, 2021

Fixing cherry-pick in another PR.

jboxman pushed a commit to jboxman-rh/openshift-docs that referenced this pull request Feb 10, 2021
jboxman added a commit that referenced this pull request Feb 10, 2021
[enterprise-4.7] CICD -Build, Pipelines and GitOps docs restructure (#29252)
@yuvalk yuvalk mentioned this pull request Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.7 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants