-
Notifications
You must be signed in to change notification settings - Fork 1.9k
CICD -Build, Pipelines and GitOps docs restructure #29252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Deploy preview for osdocs ready! Built with commit 85f4fe6 |
minor edits move docs to cicd dir dir name mod modifying xref modifying xrefs fixing xrefs fixing xrefs fixing xrefs3 fix xrefs updating xrefs updating xrefs2 updating xrefs3 updating xrefs4 xref fixes updating module name
|
/devtools |
|
@Preeticp thanks for calling out labels! |
|
I think this needs a symlink |
jboxman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the symlink for images needs to be ../.. just like the xref adjustments.
| File: working-with-pipelines-using-the-developer-perspective | ||
| - Name: OpenShift Pipelines release notes | ||
| File: op-release-notes | ||
| #- Name: GitOps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want this added, commented out? Or should that happen in a different PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we want to add this, and the entire reorg was initiated due to this component. But we don't have the content in place yet. Hence commented out. Is there a concern merging this commented out?
In the content PR we will add this with changes in the title as required, is that OK? This will come in slightly later, we spoke to Vikram and have an exception for this. Basically this component has an async release cycle from that of OCP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay.
| * xref:../../cicd/builds/creating-build-inputs.adoc#builds-input-secrets-configmaps_creating-build-inputs[Input secrets and config maps] | ||
| ifndef::openshift-origin[] | ||
| * xref:../../architecture/cicd_gitops.adoc#cicd_gitops[The CI/CD methodology and practice] | ||
| // **This section is being moved, update the link once content is in.* add link here[The CI/CD methodology and practice] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remember to update this when the time is right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will add this with the content PR.
|
@jboxman I have fixed the images issue. The others we will fix with the content PR. Hope this is good to merge, if not let me know, please. |
|
@Preeticp, I squashed the commit in GitHub. (So if you delete the branch with |
|
/cherry-pick enterprise-4.7 |
|
@jboxman: #29252 failed to apply on top of branch "enterprise-4.7": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Thank you, @jboxman |
|
Fixing cherry-pick in another PR. |
Restructure CI/CD content
[enterprise-4.7] CICD -Build, Pipelines and GitOps docs restructure (#29252)
Aligned team: DevTools
Applicable Version: 4.7
We have acks from respective team leads, and Stephanie and Vikram.